Repository navigation
Consolidate low-signal tests from recent run-records and account work - #958
Merged
Merged
Conversation
Collapses 32 tests across four files down to 15, following the 'fewer longer workflow tests' principle from testing-principles.md. run-records.workers.test.ts (20 → 9): - Merge eager-begin/finish, finish-only upsert, one-shot recordRunRecord, waitUntil non-blocking, and execute on-failure policy into a single 'write surfaces journey' test. - Delete 'sandbox level markers become structured log levels' — covered by the existing sandbox e2e test which already asserts structured log levels on each entry. - Merge retention-priority, cap-protect-running, stale-reconcile, stale-cap-evict, and age-cap scenarios into 'cap and stale retention journey' (each with its own userId for DO isolation). - Extend 'write after idle re-arms alarm and age-prunes' into a full 'alarm lifecycle' narrative that also covers the fresh-arm far-future deadline assertion and the self-termination assertion from the two standalone alarm tests. runs.workers.test.ts (5 → 2): - Keep the auth guard test unchanged. - Merge run_list filter smoke, run_get with logs/foreign/missing rejection, run_summary counts, and run_list/run_summary tenant isolation into a single 'run capabilities smoke' test. Filter/ pagination matrix remains in run-records.workers.test.ts. execute-console-capture.workers.test.ts (4 → 2): - Merge success-levels, throw-capture, and unshimmed-methods into 'console capture contract'; keep 'reused dynamic workers' separate. stripe-webhooks.workers.test.ts (3 → 2): - Fold the 503-when-secret-unset guard into the main journey test as an upfront check before any seeding. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Collapse post-#934 one-string-per-filter and sibling unit cases toward fewer longer workflow tests. - sentry-options: fold UserCodeError hint + platform keep into the main filter journey; delete standalone user-code-error.node.test.ts - d1-retry: keep representative matchers and one retry/fail path - observability: fold conversationId/storageId/detail context into the platform-bug reporting journey - activation: merge twice-same-package, HTTP ignore, sticky timestamp, fast path, and never-throw degradation - fold stripe signature fixture, package-workflow sentry tags, invocation surface/name helpers, and package_service_states count + entitlement boundary Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Fold post-#937/#939/#940 account verification tests into fewer workflow journeys and drop low-signal Playwright coverage. - account-values handler: list/select/save/delete + rejection matrix - account-memories handler: list/filter/select + soft/force delete - activity-data helpers + load/cursor; billing refresh workflow without instructional error-copy pins - auth-session password-change matrix; auth-denial and email-delivery alert cron/threshold/cooldown journeys - trim activity e2e instructional empty-state copy; drop memories e2e (values e2e + memories handler cover the pattern); drop jobs schedule text pin Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
kody-bot
marked this pull request as ready for review
July 26, 2026 09:25
Contributor
|
🔎 Preview deployed: https://kody-pr-958.kody-a99.workers.dev Worker: Mocks:
|
CI format:check uses oxfmt (tabs/single quotes). A Prettier pass had rewritten touched test files to spaces/double quotes. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
kody-bot
pushed a commit
that referenced
this pull request
Jul 27, 2026
…982) * test: consolidate low-signal suites from recent integrations and jobs work Fold post-#958 verification tests toward fewer longer workflow journeys: merge OAuth app/setup/prefill matrices, reindex retry pairs, remote-connector hello/secret lookup outcomes, account jobs filter+e2e journeys, and plan secret quota cases. Drop the run-history source-scan guardrail and SQL predicate alias pin; rewrite the package_service_states backfill fixture to exercise real rescue behavior instead of the empty no-op path. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com> * test: reset upsert mock between reindex retry scenarios The merged D1-retry journey reused the successful upsert spy in the exhaustion path, so the not-called assertion failed spuriously. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents added many verification tests while shipping run records (#955), account list/detail UIs (#937), invite-cohort readiness (#939), Stripe webhooks (#940), activation funnel (#942), and follow-on Sentry D1 blip carve-outs (#952–#954). This pass folds those suites toward the repo testing principles: fewer longer workflow tests, structured contracts over copy pins, and no one-string-per-filter / duplicate Playwright coverage.
Changes
filterSentryEvent; trim D1 blip matcher/retry catalogs; fold observability context into the platform-bug journey; delete standaloneuser-code-error.node.test.tsNet: 51 fewer
test()cases, −667 lines across 23 files. Behavior under test is unchanged.System recap — composes existing primitives (low risk)
Mode: recap · Base:
main@0461410a· Head:9dc9184cClassification: composes — test-only consolidation; no production behavior, contracts, or primitives changed.
Primitives touched
run-recordsapp-uimcp-serverbillingentitlementsusage-meteringpackage-runtimeSystem map
Test-only cleanup across recent run-records, account UI, billing, and Sentry coverage — no production edges change.
Legend: green = composes (wiring only) · amber = extended by this PR · red = new primitive · gray = context.
Before / after
Before: Fragmented write/retention/alarm siblings, one-string-per-filter Sentry/D1 carve-outs, and Playwright specs that restated handler coverage re-grew after #934.
After: Longer workflow journeys assert structured contracts without pinning instructional copy or duplicating filter matrices across layers.
Risk notes
Docs